Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #1718 menu issues. #1719

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Address #1718 menu issues. #1719

merged 1 commit into from
Dec 2, 2020

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Dec 2, 2020

Purpose / why

Address #1718 When the menu is collapsed into hamburger-lines, the landing page shows only the "About section" menu, which looks like the whole docs are real small!

What changes were made?

Pulled the main page out to be the "About" page, on the top level of the nav menu.

Verification

Test locally

Interested Parties

@Islandora/8-x-committers @dannylamb


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@manez
Copy link
Member

manez commented Dec 2, 2020

Built the docs, previewed in "mobile" view, and this seems to fix the issue. When you hit the docs, you see the entire TOC now.

@manez manez merged commit 141bdbe into Islandora:main Dec 2, 2020
@manez
Copy link
Member

manez commented Dec 2, 2020

Resolves #1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants