-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document using base box and dev branch on the playbook instructions. #1598
Conversation
* Render the example helpful tip properly. * Fix note syntax, again.
Wrong Danny tagged, I think. The current is @dannylamb |
I tried out the instructions and found them easy to follow (and clear about why you'd use dev and a different base box), but I came into it kinda aware, so I'd like to get some fresher eyes on it. Flagging this as maybe something we can ask User Call people to have a look at/run through? Also, there's some oddness going on with branches and extra commits getting pulled in, but presumably @dannylamb can comment on that alongside whatever else needs to happen to get our branches back in order. |
Git-fu accomplished; main is up to date, and this pr is now current to main. One file changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @rosiel. I don't think there's anything left to do here due to the master/main renaming.
Purpose / why
It's not actually documented
Note: i think it gets a little long; do you think it should be less verbose? I want it to be simple for people to test PRs, especially, and that means successfully provisioning dev.
in part, this documents #179, and extends the documentation on the dev branch added in #180 to the "official" documentation.
What changes were made?
Reorganized a little of the installation section for clarity.
Verification
Try it? Ideally... i'm not sure if the pre-built box, which doesn't use ansible, can be launched with the vagrant file if you dont have ansible installed.
There are a number of things that seem illogical when written out.
Interested Parties
@daniel-dgi
Checklist