Update committers.md #1370
Merged
Update committers.md #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Nov 27, 2019
| @@ -85,8 +85,8 @@ Summary: | |||
|
|
|||
| If they accept, then do: | |||
|
|
|||
| 1. Add to Committer team of GitHub Islandora organization ?? | |||
There was a problem hiding this comment.
With the split in Islandora 7 and 8, should this be
Add to the Islandora 8 Committer team of the Github Islandora organization.
whikloj
reviewed
Nov 27, 2019
| @@ -85,8 +85,8 @@ Summary: | |||
|
|
|||
| If they accept, then do: | |||
|
|
|||
| 1. Add to Committer team of GitHub Islandora organization ?? | |||
| 2. Add to Committer team of GitHub Islandora-Labs organization ?? | |||
There was a problem hiding this comment.
What does this team do? I don't think committers as a team have any greater access then a regular user, unless granted by... you maybe?
There was a problem hiding this comment.
I'm sorry, we probably have write permissions. I wasn't thinking clearly. Nevermind this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #1040
What does this Pull Request do?
Very minor clean-up on the Committers.md page. Removing some ?? marks.
Interested parties
@Islandora/8-x-committers