-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update adding _format back docs #1354
Update adding _format back docs #1354
Conversation
To turn the `?_format` parameter back on: | ||
|
||
- Go to `admin/config/search/jsonld` and confirm the *"Remove jsonld parameter from @ids"* checkbox is **unchecked**. | ||
- Add `strip_format_jsonld: false` to your Milliner config (`/var/www/html/Crayfish/Milliner/cfg/config.yaml` in Islandora-playbook) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"in Islandora-playbook" is a bit confusing. Perhaps "if deployed using the Islandora-playbook default configuration."?
- Add `strip_format_jsonld: false` to `/var/www/html/Crayfish/Milliner/cfg/config.yaml` | ||
If you **don't** do this, you can end up with two copies of your objects in your Fedora repository (one with and one without `?_format=jsonld`). You will also have two sets of triples in your triplestore. | ||
|
||
### Adding ?_format=jsonld to your URIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the third-level heading looks odd since there is only one of each heading level. Consider making this a level-two header instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the instructions and they look fine. I do have two minor edit suggestions before we merge.
GitHub Issue: #1040
What does this Pull Request do?
Updates the "Adding back ?_format=jsonld" page of Developer documentation
How should this be tested?
Read and review
Interested parties
@Islandora/8-x-committers