Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New documentation: Objects and Resource Nodes #1040 #1340

Merged
merged 13 commits into from
Nov 27, 2019
Merged

New documentation: Objects and Resource Nodes #1040 #1340

merged 13 commits into from
Nov 27, 2019

Conversation

manez
Copy link
Member

@manez manez commented Nov 18, 2019

GitHub Issue: #1040

Original document

What does this Pull Request do?

Takes the conceptual parts of @alexkent0 's document introducing Islandora 8 from an islandora 7 end-user perspective and makes a new page for our docs. This is the source of the term "resource node."

The original document has a lot of additional content that I left out, as it's covered elsewhere in our documentation, but these conceptual bits are unique.

All done with Alex's permission and approval.

What's new?

A page of conceptual documentation and a screenshot.

How should this be tested?

Preview, read through, give opinions 😄

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

@Islandora/8-x-committers and @alexkent0

Copy link
Contributor

@librarychik librarychik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a number of minor suggested edits. tagging @Islandora/8-x-committers

docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
docs/user-documentation/objects_to_resource_nodes.md Outdated Show resolved Hide resolved
manez and others added 10 commits November 20, 2019 08:38
This is a nifty way to do reviews!

Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
Co-Authored-By: Janice Banser <jbanser@gmail.com>
@manez
Copy link
Member Author

manez commented Nov 20, 2019

Thank you @librarychik ! The new commits made that super easy 😄

@manez
Copy link
Member Author

manez commented Nov 25, 2019

@Islandora/8-x-committers I think this one is ready to go in

@manez
Copy link
Member Author

manez commented Nov 26, 2019

@seth-shaw-unlv or @whikloj can I impose? I need this one merged so I can delete my fork and start over on some different stuff 😅

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @manez.

@seth-shaw-unlv
Copy link
Contributor

Ih, wait, this is a @manez pr... let me read through.

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, my only comment and it can happen later would be that a screenshot where the image viewer is not displaying an error is more polished.

@whikloj whikloj merged commit e25ca1a into Islandora:master Nov 27, 2019
@seth-shaw-unlv
Copy link
Contributor

Thanks for covering me there, @whikloj! I'm out of the office this week and got distracted before I could finish the read-through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants