-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing it all together #1084
Bringing it all together #1084
Conversation
Text for documentation on creating a collection.
Slight revisions and saved with .md at end of name.
Added screenshot files for loading media doc
Added spaces between paragraphs, alternate text, and links to screenshots.
Added screenshots for creating collection documentation.
Added alternative text and links
Added correct slashes in front of "assets" for links
Added screenshots for loading media documentation with correctly formatted filenames
Update links with properly formatted filenames
…alexkent-1-patch-3
Click save when done, and the file will be uploaded (to Fedora by default). Now return to the node | ||
you created and you should see the image along with its descriptive metadata. | ||
|
||
![The file is now loaded, return to the main site to view](/assets/final-loaded-image.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you needs an absolute URL here, it's not loading when previewed. "docs/assets/final-loaded-image.jpg"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or as the other above change to ../assets/final-loaded-image.jpg
Click save when done, and the file will be uploaded (to Fedora by default). Now return to the node | ||
you created and you should see the image along with its descriptive metadata. | ||
|
||
![The file is now loaded, return to the main site to view](/assets/final-loaded-image.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or as the other above change to ../assets/final-loaded-image.jpg
docs/index.md
Outdated
@@ -10,13 +6,3 @@ Islandora CLAW integrates [Drupal](https://www.drupal.org/) (currently, Drupal 8 | |||
Islandora CLAW allows you to create nodes, media, files, and taxonomy terms in Drupal, which are converted to RDF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/CLAW/8/
I think that hits all the feedback I've received. At least I figured out how tip boxes work with Admonition and can give them titles now. I played around with the formatting a lot. Please let me know if there's more to do here. |
@dannylamb |
@@ -0,0 +1,3 @@ | |||
<iframe width="560" height="315" src="https://www.youtube.com/embed/fEDzfSPjKEo" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using Youtube's "no cookie" URL: https://www.youtube-nocookie.com/embed/fEDzfSPjKEo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my mistake I forgot to test this by actually building the Mkdocs. This works as is.
@dannylamb This looks good now. You are missing the Once that is done I am happy to merge this. |
@whikloj OK, conflicts resolved and testing notes added back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@seth-shaw-unlv do you need anything else on this or are we good to go? |
@whikloj, nah. I don't think the youtube no cookie is important enough to hold up merging. Go ahead. |
GitHub Issue: #1040
What does this Pull Request do?
What started out as taking the excellent work from @alexkent0 and bringing it over the finish line turned into an editorial pass that just exploded in scope on me. Here's the best stopping point I could find before tackling moving over the install docs and the migrate tutorials.
What's new?
It's everything from the sprint, plus I managed to make it through the first several pages of the user docs and smooth over some things. Remove duplicated concepts, etc... Just trying to make sure the user documentation reads better, mostly.
Still needs tons of love, but it's a massive overhaul and major improvement from where we started!
How should this be tested?
I've taken the liberty of pushing the documentation to https://islandora-claw.github.io/CLAW/. I find it's much easier to digest in its final form. Please please please give it a review and leave your comments in this PR.
Interested parties
@Islandora-CLAW/committers