Skip to content

Commit

Permalink
add release notes for captions
Browse files Browse the repository at this point in the history
  • Loading branch information
@elizoller
elizoller committed Mar 18, 2021
1 parent f3a2f93 commit 17837b3
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion docs/release_notes/8.x-2.0.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,20 @@ It is recommended to test this method in a staging/development environment befor
10. Create a new object and make sure it persists to Fedora and the Fedora URI likn resolves correctly. Make sure that no new entries get added to Gemini.
11. If you're feeling brave, you can then remove Gemini like
i. `rm /var/www/html/Crayfish/Gemini`
ii. Remove the gemini database and the associated mysql user
ii. Remove the gemini database and the associated mysql user


## Adding Captions
1. Make sure you are on the most recent code of islandora and islandora_defaults (`composer update islandora/islandora islandora/islandora_defaults`)
2. Do a config import on the `config/install` directory of `islandora_defaults` or copy the changed files into another directory and import those (if you are on an existing install, i'd recommend the partial config import). The changed files are:
i. core.entity_form_display.media.audio.default
ii. core.entity_form_display.media.video.default
iii. core.entity_view_display.media.audio.default
iv. core.entity_view_display.media.audio.source
v. core.entity_view_display.media.video.default
vi. core.entity_view_display.media.video.source
vii. field.field.media.audio.field_track
viii. field.field.media.video.field_track
ix. field.storage.media.field_track
3. clear your drupal cache `drush cr`
4. You should now see a "track" field on audio and video media objects

9 comments on commit 17837b3

@kayakr
Copy link
Contributor

@kayakr kayakr commented on 17837b3 Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying this on an existing site, with islandora/islandora (dev-8.x-1.x cb52ddd) and islandora/islandora_defaults (dev-8.x-1.x 34accdd).
drush config:import sync --source=/var/www/html/drupal/web/modules/contrib/islandora_defaults/config/install --partial --diff

The import failed due to the following reasons:                                                                                                                                                                    
  Unexpected error during import with operation create for field.storage.media.field_track: Unable to determine class for field type 'media_track' found in the 'field.storage.0' configuration  
  Unexpected error during import with operation create for field.field.media.audio.field_track: Unable to determine class for field type 'media_track' found in the 'field.field.0' configurati  
  on                                                                                                                                                                                                                 
  Unexpected error during import with operation create for field.field.media.video.field_track: Unable to determine class for field type 'media_track' found in the 'field.field.0' configurati  
  on                                                                                                                                                                                                                 
  Unexpected error during import with operation update for core.entity_view_display.media.video.source: The "islandora_file_video" plugin does not exist.

Am I missing a core patch? Does this depend on Drupal 9?

@elizoller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you happen to clear your cache before trying the import? it appears not to be discovering the new classes

@kayakr
Copy link
Contributor

@kayakr kayakr commented on 17837b3 Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizoller Yes, I cleared cache. I tried the patch from https://www.drupal.org/project/drupal/issues/3056714#comment-13289619 but it doesn't apply to Drupal 8.9.13. So these changes seem to require Drupal 9.

@elizoller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that would be a problem. That patch says anyway that its written for 8.8.x. Let me spin up D8 site and give it a whirl.

@elizoller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started back up an old-ish d8 vm i had (december 2020 build) and pulled in the latest islandora and islandora_defaults code. then I ran

drush config:import --partial --source /var/www/html/drupal/web/modules/contrib/islandora_defaults/config/install/

and got the same error you did about about Unable to determine class for field type media_track
then i ran drush cr
and the same command again

drush config:import --partial --source /var/www/html/drupal/web/modules/contrib/islandora_defaults/config/install/

and it succeeded and then i ran drush updatedb and updated crayfish-commons (unrelated to captions but related to no-gemini stuff) went to the UI and was able to create an item with an attached video media with a captions file.

@kayakr
Copy link
Contributor

@kayakr kayakr commented on 17837b3 Mar 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizoller Thanks for checking it out. Unfortunately, I still get the Unexpected error during import with operation create for field.storage.media.field_track: Unable to determine class for field type 'media_track' found in the 'field.storage.0' configuration error.
Where exactly did you get a media_track from? A patch?
I don't see it in my codebase other than the references in web/modules/contrib/islandora_defaults/config/install/.

@kayakr
Copy link
Contributor

@kayakr kayakr commented on 17837b3 Mar 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizoller fyi, I was able to apply the patch from https://www.drupal.org/files/issues/2019-10-07/3056714-16.patch in a separate VM, so it looks like I have a local issue with composer. But if that patch is a prerequisite for captions then these docs need to specify the details of the core patch...

@elizoller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you do not need the core patch, this is a replacement for the core patch.

@kayakr
Copy link
Contributor

@kayakr kayakr commented on 17837b3 Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizoller Aha, I hadn't seen the latest commit. I see media_track arrives via https://github.com/Islandora/islandora_defaults/pull/48/files#diff-fac75faa98b4ecbbf46f6944c29fba9d8f73e69ee9e639e5fb968d6ef19a0a1dR15

Please sign in to comment.