Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More schema definition fun. #85

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

adam-vessey
Copy link
Contributor

GitHub Issue: Islandora/documentation#2164

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Fleshes out config schema.

What's new?

A number of new config schemas being defined. Later exports may end up changing the types of values stored in exported YAML; for example: If something is now defined as a boolean, it should now be exported as a true or false whereas before it would've likely been the integers 1 or 0... shouldn't really have any effect, just might cause a bit of noise in diffs as it happens.

  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Unlikely.

How should this be tested?

  1. Install and enable the config_inspector module

  2. Either:

    1. Run:
      drush config:inspect --only-error --detail
      
      or:
    2. Looks at the reports at /admin/reports/config-inspector

    to note the number of config errors present from the plugins defined in Islandora.

  3. Grab the code

  4. Clear cache

  5. Re-run/Look at the config_inspector output, and see that the number of errors should be reduced.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a bunch of missing schema errors 👍

@whikloj whikloj merged commit 9598fca into Islandora:2.x Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants