Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2164
Release pull requests, etc.)
What does this Pull Request do?
Fleshes out config schema.
What's new?
A number of new config schemas being defined. Later exports may end up changing the types of values stored in exported YAML; for example: If something is now defined as a
boolean
, it should now be exported as atrue
orfalse
whereas before it would've likely been the integers1
or0
... shouldn't really have any effect, just might cause a bit of noise in diffs as it happens.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Install and enable the
config_inspector
moduleEither:
/admin/reports/config-inspector
to note the number of config errors present from the plugins defined in Islandora.
Grab the code
Clear cache
Re-run/Look at the config_inspector output, and see that the number of errors should be reduced.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers