Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separated typed relation field into its own category #60

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

elizoller
Copy link
Member

GitHub Issue: (Islandora/documentation#1715)

What does this Pull Request do?

Separates the typed relation field into its own category

What's new?

a doc comment change that separates the typed relation field into its own category so those fields are easier to distinguish from regular entity reference fields

How should this be tested?

  • Pull in the PR
  • Cache clear
  • Go to create a new field on an existing content type
  • See typed relation fields separately
  • Create a field just to be sure it still works

Additional Notes:

Screenshot:
Screen Shot 2020-11-25 at 1 09 16 PM

Interested parties

@Islandora/8-x-committers @antbrown

@antbrown
Copy link

+1 this works for me and resolves the issue I was having in Islandora/documentation#1715

@mjordan mjordan self-requested a review December 2, 2020 18:38
Copy link
Contributor

@mjordan mjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during 2020-12-02 Tech call.

@@ -14,6 +14,7 @@
* id = "typed_relation",
* label = @Translation("Typed Relation"),
* module = "controlled_access_terms",
* category = @Translation("Typed Relation"),
* description = @Translation("Implements a typed relation field"),
* default_formatter = "typed_relation_default",
* default_widget = "typed_relation_default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by community, ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants