Index date intervals that use null as one of the ends. #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #109
Release pull requests, etc.)
What does this Pull Request do?
Indexes EDTF years for dates formatted as intervals where one end (start or end) is just null, e.g.
2020/
or/1999
.Removes error messages "Could not parse EDTF value 2020/ for node/nid".
What's new?
Looks for
/
as well as../
as signifier of an empty start of interval, and/
as well as/..
at the end of an interval.Also switches to use the calculated
$end_year
being the current year or the configured "end date value" in the EDTF Year processor. It looks like this was created but never implemented.Does this change require documentation to be updated? no
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? You may want to re-index your content if you have nulls in your intervals.
Could this change impact execution of existing code? no
How should this be tested?
Recreate issue #109
1999/
itm_edtf_year
field is empty.With this PR:
itm_edtf_year
holds all the configured values.Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag @seth-shaw-asu