Use syntax that works with http-foundation 6. #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Solves the problem that advanced search doesn't work in drupal 10.
Related GitHub Issue: [BUG] Advanced Search breaks in Drupal 10 (symfony/http-foundation v6) #35
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
Gets a query parameter in a way that accepts arrays or scalars.
Does this change add any new dependencies? no, this also works in http-foundation 4 (drupal 9 version)
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no
How should this be tested?
Launch a site that is running Drupal 10. Until site-template gets fixed, either:
Create some content. Note that you can't use advanced search to find the content and errors appear in the logs. (replicate the bug).
With this PR, you should be able to find content and the logs should have no errors.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers