-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade symfony to 5.4 & separate EntityMapper #174
Conversation
Switch to lexik_jwt_bundle Milliner need islandora-fedora-entity-mapper but not Crayfish-Commons
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 4.x #174 +/- ##
============================================
- Coverage 76.93% 76.72% -0.21%
Complexity 160 160
============================================
Files 6 6
Lines 711 782 +71
============================================
+ Hits 547 600 +53
- Misses 164 182 +18 ☔ View full report in Codecov by Sentry. |
Thinking about this I decided to make a new 4.x branch as this changes the version of Symfony and as such would not be a simple overlay. It will require changes to your configuration which I may have to write. |
GitHub Issue: Islandora/documentation#2220
Relies on
What does this Pull Request do?
chullo
andfedora-entity-mapper
What's new?
How should this be tested?
See the full build PR on islandora-playbook here (Islandora-Devops/islandora-playbook#263)
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers