Update CONTRIBUTING.md #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #104 +/- ##
=========================================
Coverage 94.85% 94.85%
Complexity 168 168
=========================================
Files 9 9
Lines 700 700
=========================================
Hits 664 664
Misses 36 36 Continue to review full report at Codecov.
|
rosiel
approved these changes
Aug 24, 2020
dannylamb
added a commit
that referenced
this pull request
Sep 11, 2020
* add separate routes in milliner for versioning nodes and media * separate createVersion for node and Media as much as possible, create a helper method for getting the file from the media, flesh out the method for creating a media version * remove excess log statements * code cleanup * fix node versioning - no gemini from the controller so made a helper method in the service instead * adding and updating tests - still some of these fail * Bump symfony/http-foundation from 3.4.30 to 3.4.36 in /Hypercube (#92) Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.4.30 to 3.4.36. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](symfony/http-foundation@v3.4.30...v3.4.36) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump symfony/http-foundation from 3.4.30 to 3.4.36 in /Milliner (#94) Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.4.30 to 3.4.36. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](symfony/http-foundation@v3.4.30...v3.4.36) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump symfony/http-foundation from 3.4.30 to 3.4.36 in /Recast (#91) Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.4.30 to 3.4.36. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](symfony/http-foundation@v3.4.30...v3.4.36) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump symfony/http-foundation from 3.4.30 to 3.4.38 in /Gemini (#101) Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.4.30 to 3.4.38. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](symfony/http-foundation@v3.4.30...v3.4.38) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump symfony/http-foundation from 3.4.30 to 3.4.38 in /Homarus (#98) Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.4.30 to 3.4.38. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](symfony/http-foundation@v3.4.30...v3.4.38) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CONTRIBUTING.md (#104) * Update .travis.yml (#105) * Master -> Main Rename (#106) * removing unnecessary logging * update Milliner composer dependencies * add separate routes in milliner for versioning nodes and media * separate createVersion for node and Media as much as possible, create a helper method for getting the file from the media, flesh out the method for creating a media version * remove excess log statements * code cleanup * fix node versioning - no gemini from the controller so made a helper method in the service instead * adding and updating tests - still some of these fail * removing unnecessary logging * update Milliner composer dependencies * fix erroring test * fix spacing in test * update tests - copy paste from @dannylamb Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melissa Anez <manez@islandora.ca> Co-authored-by: dannylamb <dlamb@islandora.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1588
What does this Pull Request do?
Adds mention of the new User Call to CONTRIBUTING.md.
How should this be tested?
Preview & review
Interested parties
@Islandora/8-x-committers