Add grouped filter to accommodate null external uris in model. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack conversations:
It was found that the OAI view of MODS breaks (shows
<error code="idDoesNotExist">The value of the identifier argument is unknown or illegal in this repository.</error>) if the object's model has no external uri. This can happen if creating custom models.The view clearly was not meant to exclude objects with null external URI in their Model. After testing, it seems that a views filter of "value is not equal to some-string" also excludes rows where the value does not exist.
This PR adds a grouped filter so it tests if Model's external URI (is null or is not equal to
http://purl.org/dc/dcmitype/Collection).