Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the thumbnail display for image media to not use image styles. #126

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Feb 6, 2024

This is a "quick fix" regarding a discussion in Slack regarding broken thumbnails caused by Drupal trying to create "Image Style" derivatives in the fedora flysystem when browsing as anonymous.

This "fix" shows thumbnail images at their original size. A paired PR resizes the Demo objects' thumbnails to be the same height (220x220) as the "medium" image style removed here.

If you are using the starter site, be aware that you should make your thumbnails "thumbnail sized". (if you use Fedora at all. Or, see below)

A better fix is for the Fedora Flysystem adapter to declare Fedora as non-writable when browsing as anonymous. Then image style derivatives should be created in public://. See issue: Islandora/documentation#2282

This is a quick fix in anticipation of someone with the capabilities of tackling the solution above.

@aOelschlager aOelschlager self-requested a review February 8, 2024 00:12
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to view the thumbnails in incognito mode after spinning up a new site and populating it with demo content.

@aOelschlager aOelschlager merged commit b2047e5 into main Feb 21, 2024
4 checks passed
@rosiel rosiel deleted the thumbs-original-size branch February 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants