Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Rights to formatted text. #102

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Change Rights to formatted text. #102

merged 2 commits into from
Aug 16, 2023

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jul 11, 2023

As suggested by the MIG, the Rights field would be more useful as a formattable text field that can include links, images, etc.

@rosiel
Copy link
Contributor Author

rosiel commented Jul 12, 2023

Change cardinality to -1.

@rosiel
Copy link
Contributor Author

rosiel commented Jul 12, 2023

Testing:
Rebuild a starter site by using this PR;

  • load some data including rights field info
  • Check that it displays on the node and is searchable.

@aOelschlager aOelschlager self-requested a review July 19, 2023 17:21
aOelschlager
aOelschlager approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested per instructions in pr. It works.

@aOelschlager aOelschlager merged commit 6033567 into main Aug 16, 2023
@rosiel rosiel mentioned this pull request Oct 31, 2023
Closed
@rosiel rosiel deleted the field_rights_formatted branch October 31, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aOelschlager aOelschlager aOelschlager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosiel @aOelschlager