Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intl extension for php #277

Merged
merged 1 commit into from
May 29, 2024
Merged

Add intl extension for php #277

merged 1 commit into from
May 29, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented May 22, 2024

GitHub Issue: #276

What does this Pull Request do?

playbook fails with modern starter site since the changes to citation select that requires the citeproc library directly.

Adds the intl php extension so it works again.

What's new?

See diff.

How should this be tested?

  • run playbook, it fails (see issue)
  • with this fix, it works.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

Copy link
Contributor

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-asu seth-shaw-asu merged commit 44e8eab into dev May 29, 2024
@joecorall joecorall deleted the rosiel-patch-1 branch May 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants