Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starter #267

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Update starter #267

merged 2 commits into from
Jun 30, 2023

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jun 19, 2023

GitHub Issue: see slack: https://islandora.slack.com/archives/C019U12D44Q/p1687185644319709

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Updates which minimum version of the starter site to use when using the starter option.

What's new?

  • Changes 0.2 (old!) to 0.7 (new)
  • switches ^ for ~ to hopefully treat pre-release versions more leniently.

The composer docs don't outright say, but imply that the tilde operator will get the latest 0.x release.

How should this be tested?

Create a site with starter. You should get the 0.2 release. There will be no advanced search - that's the biggest different on the front page. (before advanced search, the search box is in the sidebar. With advanced search, it's a long search bar in the header).

After this pull:
Create a site with starter. You should get the latest release.
Testing the "latest" ness - before spinning up, change the version constraint to ~0.6. Then compare the version in the .starter_site_version file. It should still be 0.7.

If the "latest" feature doesn't work, that's good to know but should not prevent this PR which is useful anyway. If that's the case then we'll push out a 1.0 release sooner.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

@seth-shaw-asu seth-shaw-asu self-requested a review June 28, 2023 17:31
Copy link
Contributor

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Including

Testing the "latest" ness - before spinning up, change the version constraint to ~0.6. Then compare the version in the .starter_site_version file. It should still be 0.7.

@seth-shaw-asu seth-shaw-asu merged commit 5e6fc18 into Islandora-Devops:dev Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants