Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow-list composer plugins #217

Closed
wants to merge 4 commits into from
Closed

Allow-list composer plugins #217

wants to merge 4 commits into from

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Jun 8, 2022

GitHub Issue: (link)

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

Discussion of composer's plans to disallow plugins by default starting in July 2022:

https://www.drupal.org/project/drupal/issues/3255749

What does this Pull Request do?

Explicitly allows composer plugins that Drupal uses.

What's new?

grab latest releases.

Add the composer plugins Drupal uses to an explicit allow list to avoid possible breaking behaviour starting July 2022.

  • Does this change require documentation to be updated?

No

  • Does this change add any new dependencies?

No

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?

No

  • Could this change impact execution of existing code?

Existing Drupal sites should not be affected. New installs will default to stable version of Drupal core.

How should this be tested?

Run a fresh playbook install.

Test object creation to ensure derivatives are generated.

Run a composer command while logged in as vagrant. You should not get a warning about allowed plugins

Additional Notes:

The 'acl' Ubuntu package was added to get around a problem with newer versions of Ansible when running as a less-privileged user. See: ansible/ansible#74830

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

@alxp alxp changed the title Force stable Drupal version, allow-list composer plugins Allow-list composer plugins Jun 8, 2022
@alxp alxp marked this pull request as draft June 8, 2022 17:12
@rosiel
Copy link
Contributor

rosiel commented Jul 13, 2022

The composer-plugins-fix task never seemed to work. We're reducing the need for this with #221 .

@alxp alxp closed this Jul 14, 2022
@alxp alxp deleted the composer-stability branch July 14, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants