Skip to content

Feature: Signers & Verifiers #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
33 commits merged into from
Jun 8, 2022
Merged

Feature: Signers & Verifiers #8

33 commits merged into from
Jun 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2022

Adds signing and verification support for: algorand, cosmos, ethereum and erc20 ones.

@ghost ghost force-pushed the feat/verifiers branch from 1bc369f to 8284021 Compare May 24, 2022 18:03
Copy link
Contributor

@mikonieminen mikonieminen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, but I cannot really comment on the correctness of the logic. Otherwise looks good to me.


assert!(ArweaveSigner::verify(pub_key, msg.clone(), sig).is_ok());

let jwt_str = r#"{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be jwk_str, not jwt_str.

@ghost ghost force-pushed the feat/verifiers branch from 864377c to 2c5cd68 Compare June 7, 2022 16:16
@ghost ghost force-pushed the feat/verifiers branch from 2c5cd68 to 5fa7428 Compare June 7, 2022 16:18
@ghost
Copy link
Author

ghost commented Jun 7, 2022

Just fixing signature errors, commit contents still unchanged

@ghost ghost merged commit c433538 into master Jun 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants