Refactor/arweave feat #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Aug 17, 2022
ghost
merged commit 
|
@bluekirby1111 is it ok for me to make a release with these changes? |
|
Yep thanks @samuelvanderwaal |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the arweave module and signer behind a feature but adds it to the default features list. The Metaplex Sugar CLI relies on Solana libraries that have a
zeroizedependency that is in conflict with the one used byrsawhich is used by thearweavemodule. Fortunately, Sugar CLI does not use the arweave module at all so we can just disable default features and only use the one we need.