Mixin ConfigManager replaces booleans in refixes config#7
Open
Xytronix wants to merge 3 commits intoIroriPowered:masterfrom
Open
Mixin ConfigManager replaces booleans in refixes config#7Xytronix wants to merge 3 commits intoIroriPowered:masterfrom
Xytronix wants to merge 3 commits intoIroriPowered:masterfrom
Conversation
9 tasks
Contributor
Author
{
"Mixins": {
"MixinFluidPlugin": true,
"MixinFluidReplicateChanges": false,
"MixinBlockModule": true,
"MixinBlockComponentChunk": true,
"MixinBlockHealthSystem": true,
"MixinChunkReplicateChanges": false,
"MixinChunkSavingSystems": true,
"MixinArchetypeChunk": true,
"MixinEntityTickingSystem": false,
"MixinStore": false,
"MixinCommandBuffer": true,
"MixinRemovalSystem": true,
"MixinUUIDSystem": true,
"MixinCollectVisible": true,
"MixinKDTree": true,
"MixinTickingThread": true,
"MixinTickingThreadAssert": true,
"MixinTickingSpawnMarkerSystem": true,
"MixinPlayerChunkTrackerSystems": true,
"MixinGamePacketHandler": true,
"MixinInteractionChain": true,
"MixinInteractionManager": true,
"MixinSetMemoriesCapacityInteraction": true,
"MixinCraftingManagerAccessor": true,
"MixinWorld": true,
"MixinWorldConfig": true,
"MixinWorldMapTracker": true,
"MixinWorldSpawningSystem": true,
"MixinUniverse": true,
"MixinPrefabLoader": true,
"MixinInstancesPlugin": true,
"MixinPortalDeviceSummonPage": true,
"MixinPortalWorldAccessor": true,
"MixinTrackedPlacementAccessor": true,
"MixinTrackedPlacementOnAddRemove": true,
"MixinBeaconAddRemoveSystem": true,
"MixinMarkerAddRemoveSystem": true,
"MixinHytaleServer": true,
"MixinHytaleServerConfig": false
}
}Should we leave all of them enabled by default? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I migrated several mixin toggles to a dedicated plugin (
RefixesMixinPlugin).This avoids conditional statements in prior mixins and simplifies runtime loading of Mixins.
A user can now disable each mixin on their own. Several mixins are kept as default false.
This is done through a new file
mods/IroriPowered_Refixes/Refixes.json.Type of change
Implementation details
early/src/main/java/cc/irori/refixes/early/RefixesMixinPlugin.javamods/IroriPowered_Refixes/Refixes.jsonMixinssection back to config, and blocks disabled mixins inshouldApplyMixin.early/src/main/resources/refixes.mixins.json(added"plugin"property)MixinStateSupportfrom active mixins.early/.../MixinBlockModule.javaearly/.../MixinCollectVisible.javaearly/.../MixinEntityTickingSystem.javaearly/.../MixinFluidPlugin.javaearly/.../MixinHytaleServerConfig.javaearly/.../MixinInstancesPlugin.javaearly/.../MixinKDTree.javaearly/.../MixinStore.javaearly/.../MixinTickingThread.javaEarlyOptionsby removing now-unused boolean fields:early/src/main/java/cc/irori/refixes/early/EarlyOptions.javaplugin/src/main/java/cc/irori/refixes/Refixes.javaplugin/src/main/java/cc/irori/refixes/config/impl/RefixesConfig.javaplugin/src/main/java/cc/irori/refixes/config/impl/ExperimentalConfig.java(deleted)Checklist
spotlessApplywhen necessary)Additional info