Add MixinHideEntitySystems to prevent world crash on cross-world teleport#16
Open
Dimotai wants to merge 10 commits intoIroriPowered:masterfrom
Open
Add MixinHideEntitySystems to prevent world crash on cross-world teleport#16Dimotai wants to merge 10 commits intoIroriPowered:masterfrom
Dimotai wants to merge 10 commits intoIroriPowered:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
MixinHideEntitySystemsto catchIllegalStateException: Invalid entity reference!inHideEntitySystems$AdventurePlayerSystem.tick(). This crash occurs when a player teleports between worlds and their entity reference is invalidated mid-tick, crashing the entire world thread and disconnecting all players.Related issues
Type of change
Implementation details
Adds
MixinHideEntitySystems.javatargetingHideEntitySystems$AdventurePlayerSystem. Uses the same wrap-and-rethrow pattern asMixinStateSupport— injects at HEAD oftick(), wraps the original call in a try/catch forIllegalStateException, and logs a warning instead of crashing. Uses aThreadLocal<Boolean>re-entry guard to prevent infinite recursion.Stack trace from production server (15-20 concurrent players):
Files changed:
early/src/main/java/.../mixin/MixinHideEntitySystems.java(new)early/src/main/resources/refixes.mixins.json(added registration)Checklist
spotlessApplywhen necessary)Additional info
Tested on a production Hytale server (Histatu). The mixin loads cleanly and the server boots without errors. The fix only activates on the exact code path that would have crashed the world thread — normal tick execution is unaffected.