Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for older versions of node #18

Merged
merged 1 commit into from
Feb 21, 2016
Merged

Add compatibility for older versions of node #18

merged 1 commit into from
Feb 21, 2016

Conversation

redonkulus
Copy link
Contributor

@IonicaBizau

I'm building a utility that leverages this library but must run on an older version of Node (0.10 and 0.12). Changing this one line makes it work. Normally I would not make a change like this but given it looks like the only use of ES2015 in the file, it seems harmless.

@IonicaBizau
Copy link
Owner

@redonkulus Thanks!

The problem is that the dependencies also use const (any possibly other ES2015 features). For example, in the is-ssh package we have the same problem.

Maybe adding a prepublish script here that will bundle and babelify everything would be a solution?

Glad to hear you're using this module! 😁

@redonkulus
Copy link
Contributor Author

@IonicaBizau I also just noticed that other parts of this file use let and template strings so it wasn't as easy as I thought. You raise a good point about the dependencies.

As for the prepublish script, that would help me as well. Frustrating to have to cater to older environments, but I'd bet there is a large population of users that still use these older environments.

@IonicaBizau
Copy link
Owner

As for the prepublish script, that would help me as well.

OK, I'm on it. 😁

@redonkulus
Copy link
Contributor Author

Oh awesome, appreciate it!

@IonicaBizau
Copy link
Owner

@redonkulus Check out the bundle branch. It requires the dist/index.js file that should be compatible. Soon will merge it.

@IonicaBizau IonicaBizau merged commit 3959196 into IonicaBizau:master Feb 21, 2016
@IonicaBizau
Copy link
Owner

@redonkulus Check out 6.0.1–the main file points to dist/index.js which is bundled, babelified and uglified.

I use dist-it@2.0.0 to bundle, babelify and minify everything. 📦

@redonkulus redonkulus deleted the patch-1 branch February 21, 2016 14:14
@redonkulus
Copy link
Contributor Author

@IonicaBizau perfect, works great now. Thanks for the fast turn around!

@IonicaBizau
Copy link
Owner

@redonkulus Glad to hear! 👍 You're welcome! 🎉

@IonicaBizau IonicaBizau mentioned this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants