-
Notifications
You must be signed in to change notification settings - Fork 21
Add favicon to client #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Rename reference in index.html - Add icon from IonelPopJara#1 (comment)
|
Hello! Thanks for adding the favicon, I had it in my TODO list but I never got to do it. I like the one you made, it looks pretty good :). This PR is marked as a draft, are you planning on modifying anything else? |
|
All credit for the icon goes out to @joeyshi12 (who posted it in the comment linked to in the commit message). To reply to your comment, @IonelPopJara, yes, I do still potentially want to modify it. For the following reasons:
|
|
I see @Lampe2020. The issue with the favicon is due to the fact that I perform SSR (server side rendering) so by editing the client, only the main page will change its favicon. If you want all pages to have a favicon, the I didn't have time to write a readme for the client but what did you try to do to run it and what result did you get? |
|
A setup script that takes the current state of the local clone and deploys it on the current machine would be nice, because the instructions are both incomplete and somewhat confusing where existing. Because you should know your code base really well, can't you extend this PR so it adds the favicon to all user-facing pages? I'll push some commits that I think will work as well over the coming few days (I'm quite busy, so only slow progress from me) but have marked this PR to accept edits by maintainers so you can do so too incase I don't get anywhere significant anytime soon. Otherwise just taking it as it is right now would also be okay, so at least the starting page has a favicon (if you want to do that, tell me so I can mark this ready for review). |
|
As the |
I don't think this adds it to the API pages as well (which is probably necessary as those are visible to the user), but at least on the start page is should appear.
Fixes #1.