Skip to content

Conversation

@Lampe2020
Copy link

@Lampe2020 Lampe2020 commented May 17, 2025

I don't think this adds it to the API pages as well (which is probably necessary as those are visible to the user), but at least on the start page is should appear.
Fixes #1.

- Rename reference in index.html
- Add icon from IonelPopJara#1 (comment)
@IonelPopJara
Copy link
Owner

Hello! Thanks for adding the favicon, I had it in my TODO list but I never got to do it. I like the one you made, it looks pretty good :). This PR is marked as a draft, are you planning on modifying anything else?

@Lampe2020
Copy link
Author

All credit for the icon goes out to @joeyshi12 (who posted it in the comment linked to in the commit message).

To reply to your comment, @IonelPopJara, yes, I do still potentially want to modify it. For the following reasons:

  1. I seem to be too dumb to get it up and running on my system, so I cannot seem to test if the icon would actually get transferred to the right place in prod (so if the file needs to be included in some list for example, that's not done yet), so if you could test that on your end that would be nice.
  2. Only the start page has that favicon, the search result page and all other pages not. That could be worked around by simply making a 256x256px rasterized version in Windows Icon format and place it as <webroot>/favicon.ico, because it is common practice for browsers to attempt to fetch the favicon from there if none is specified in the current document, to still be able to display one.

@IonelPopJara
Copy link
Owner

I see @Lampe2020. The issue with the favicon is due to the fact that I perform SSR (server side rendering) so by editing the client, only the main page will change its favicon. If you want all pages to have a favicon, the query-engine service needs to be modified as well.

I didn't have time to write a readme for the client but what did you try to do to run it and what result did you get?

@Lampe2020
Copy link
Author

Lampe2020 commented May 19, 2025

A setup script that takes the current state of the local clone and deploys it on the current machine would be nice, because the instructions are both incomplete and somewhat confusing where existing.
So I just opened the client's index.html in my browser through a python3 -m http.server in the same directory and checked out if it appeared in the tab bar. It did. And because clicking the search button opens https://api.moogle.app/ anyways I could not test that as easily.

Because you should know your code base really well, can't you extend this PR so it adds the favicon to all user-facing pages? I'll push some commits that I think will work as well over the coming few days (I'm quite busy, so only slow progress from me) but have marked this PR to accept edits by maintainers so you can do so too incase I don't get anywhere significant anytime soon. Otherwise just taking it as it is right now would also be okay, so at least the starting page has a favicon (if you want to do that, tell me so I can mark this ready for review).

@Lampe2020
Copy link
Author

As the api. subdomain is down now anyways I think this can be merged as-is, so it at least looks nice on the front page. If I ever get around to it I can open a separate PR for the other pages.

@Lampe2020 Lampe2020 marked this pull request as ready for review June 1, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No favicon in client

2 participants