[BUG]ixc does not compile the deps. when run with args outside of dependants folder. #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add additional 'WaitForExit' when dotnet process is called to add dependencies - corrects the sequence of installation and dependency retrieval.
PTKu
deleted the
377-bugixc-does-not-compile-the-deps-when-run-with-args-outside-of-dependants-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
AXSharpConfig.jsonfile. The path must be relative to the apax folder where theAXSharpConfig.json is located.Fix
The compiler now handles correctly arguments from the cli providing valid access to project dependencies.
Details
This pull request focuses on improving path handling, enhancing logging capabilities, and ensuring consistency in project file references. The most important changes include the introduction of a method to verify relative paths, modifications to logging configurations, and updates to project file references.
Path Handling Improvements:
VerifyRelativePathmethod to ensure paths are relative to the base folder and not absolute (src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpConfig.cs).RetrieveAXSharpConfigto useVerifyRelativePathfor settingOutputProjectFolder(src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpConfig.cs).Logging Enhancements:
ConfigureLoggermethod to set up different logging levels (src/AXSharp.compiler/src/AXSharp.Compiler/Logger/CompilerLogger.cs).src/AXSharp.compiler/src/AXSharp.Compiler/AxProject.cs). [1] [2]Project File Reference Updates:
IxProjectFiletoCsProjectFileand updated references accordingly (src/AXSharp.compiler/src/AXSharp.Cs.Compiler/CsProject.cs). [1] [2] [3]GetDirectDependencies(src/AXSharp.compiler/src/AXSharp.Cs.Compiler/CsProject.cs).Other Notable Changes:
src/AXSharp.compiler/src/AXSharp.Cs.Compiler/Helpers/SemanticsHelpers.cs). [1] [2]launchSettings.jsonto include new command line arguments and working directories (src/AXSharp.compiler/src/ixc/Properties/launchSettings.json). [1] [2]closes [BUG]ixc does not compile the deps. when run with args outside of dependants folder. #377