Upgrading truffle, fixing coverage and adding codecov.io (Synthetixio#452)

Author: justin j. moses

.gitignore

@@ -29,4 +29,5 @@ keys.json
 .vscode/launch.json
 
 .DS_Store
-
+coverage.json
+coverage

.solcover.js

@@ -0,0 +1,14 @@
+module.exports = {
+  port: 8545,
+  skipFiles: ['test-helpers/PublicSafeDecimalMath.sol', 'test-helpers/PublicMath.sol'],
+  client: require('ganache-cli'), // use ganache-cli version listed in dev deps
+  providerOptions: {
+    default_balance_ether: 10000000000000, // extra zero just in case (coverage consumes more gas)
+    time: new Date("2019-03-06T00:00:00"),
+    network_id: 55
+  },
+  mocha: {
+    grep: "@cov-skip", // Find everything with this tag
+    invert: true       // Run the grep's inverse set.
+  }
+};

.travis.yml

@@ -2,8 +2,9 @@ sudo: enabled
 language: node_js
 node_js:
   - 10.16.3
-before_install:
-  - npm ci
+env:
+  - COVERAGE=1
+  - GAS=1
 script:
-  - npm test
-  - npx codechecks # report gas back to GitHub
+  - if [ "$COVERAGE" = "1" ]; then npm run coverage && bash <(curl -s https://codecov.io/bash); fi
+  - if [ "$GAS" = "1" ]; then npm ci && npm test && npx codechecks; fi

migrations/2_deploy_synthetix_system.js

@@ -67,22 +67,22 @@ module.exports = async function(deployer, network, accounts) {
 	// Math library
 	// ----------------
 	console.log(gray('Deploying Math library...'));
-	deployer.link(SafeDecimalMath, MathLib);
+	await deployer.link(SafeDecimalMath, MathLib);
 	await deploy(MathLib, { from: deployerAccount });
 
 	// The PublicSafeDecimalMath contract is not used in a standalone way on mainnet, this is for testing
 	// ----------------
 	// Public Safe Decimal Math Library
 	// ----------------
-	deployer.link(SafeDecimalMath, PublicSafeDecimalMath);
+	await deployer.link(SafeDecimalMath, PublicSafeDecimalMath);
 	await deploy(PublicSafeDecimalMath, { from: deployerAccount });
 
 	// The PublicMath contract is not used in a standalone way on mainnet, this is for testing
 	// ----------------
 	// Public Math Library
 	// ----------------
-	deployer.link(SafeDecimalMath, PublicMath);
-	deployer.link(MathLib, PublicMath);
+	await deployer.link(SafeDecimalMath, PublicMath);
+	await deployer.link(MathLib, PublicMath);
 	await deploy(PublicMath, { from: deployerAccount });
 
 	// ----------------
@@ -95,7 +95,7 @@ module.exports = async function(deployer, network, accounts) {
 	// Exchange Rates
 	// ----------------
 	console.log(gray('Deploying ExchangeRates...'));
-	deployer.link(SafeDecimalMath, ExchangeRates);
+	await deployer.link(SafeDecimalMath, ExchangeRates);
 	const exchangeRates = await deploy(
 		ExchangeRates,
 		owner,
@@ -123,7 +123,7 @@ module.exports = async function(deployer, network, accounts) {
 	// ----------------
 	console.log(gray('Deploying SynthetixState...'));
 	// constructor(address _owner, address _associatedContract)
-	deployer.link(SafeDecimalMath, SynthetixState);
+	await deployer.link(SafeDecimalMath, SynthetixState);
 	const synthetixState = await deploy(SynthetixState, owner, ZERO_ADDRESS, {
 		from: deployerAccount,
 	});
@@ -144,19 +144,19 @@ module.exports = async function(deployer, network, accounts) {
 	const feePoolProxy = await Proxy.new(owner, { from: deployerAccount });
 
 	console.log(gray('Deploying FeePoolState...'));
-	deployer.link(SafeDecimalMath, FeePoolState);
+	await deployer.link(SafeDecimalMath, FeePoolState);
 	const feePoolState = await deploy(FeePoolState, owner, ZERO_ADDRESS, {
 		from: deployerAccount,
 	});
 
 	console.log(gray('Deploying FeePoolEternalStorage...'));
-	deployer.link(SafeDecimalMath, FeePoolEternalStorage);
+	await deployer.link(SafeDecimalMath, FeePoolEternalStorage);
 	const feePoolEternalStorage = await deploy(FeePoolEternalStorage, owner, ZERO_ADDRESS, {
 		from: deployerAccount,
 	});
 
 	console.log(gray('Deploying FeePool...'));
-	deployer.link(SafeDecimalMath, FeePool);
+	await deployer.link(SafeDecimalMath, FeePool);
 	const feePool = await deploy(
 		FeePool,
 		feePoolProxy.address,
@@ -198,8 +198,8 @@ module.exports = async function(deployer, network, accounts) {
 	// ----------------
 	console.log(gray('Deploying SupplySchedule...'));
 	// constructor(address _owner)
-	deployer.link(SafeDecimalMath, SupplySchedule);
-	deployer.link(MathLib, SupplySchedule);
+	await deployer.link(SafeDecimalMath, SupplySchedule);
+	await deployer.link(MathLib, SupplySchedule);
 
 	const lastMintEvent = 0; // No mint event, weeksSinceIssuance will use inflation start date
 	const weeksOfRewardSupply = 0;
@@ -218,7 +218,8 @@ module.exports = async function(deployer, network, accounts) {
 	});
 
 	console.log(gray('Deploying Synthetix...'));
-	deployer.link(SafeDecimalMath, Synthetix);
+	await deployer.link(SafeDecimalMath, Synthetix);
+	const block = await web3.eth.getBlock('latest');
 	const synthetix = await deploy(
 		Synthetix,
 		synthetixProxy.address,
@@ -228,7 +229,7 @@ module.exports = async function(deployer, network, accounts) {
 		resolver.address,
 		{
 			from: deployerAccount,
-			gas: 8000000,
+			gas: block.gasLimit,
 		}
 	);
 
@@ -289,7 +290,7 @@ module.exports = async function(deployer, network, accounts) {
 
 	const synths = [];
 
-	deployer.link(SafeDecimalMath, PurgeableSynth);
+	await deployer.link(SafeDecimalMath, PurgeableSynth);
 
 	for (const currencyKey of currencyKeys) {
 		console.log(gray(`Deploying SynthTokenState for ${currencyKey}...`));
@@ -351,7 +352,7 @@ module.exports = async function(deployer, network, accounts) {
 	// Depot
 	// --------------------
 	console.log(gray('Deploying Depot...'));
-	deployer.link(SafeDecimalMath, Depot);
+	await deployer.link(SafeDecimalMath, Depot);
 	const depot = await deploy(Depot, owner, fundsWallet, resolver.address, {
 		from: deployerAccount,
 	});
@@ -363,7 +364,7 @@ module.exports = async function(deployer, network, accounts) {
 	// Needs the SynthsETH & SynthsUSD in the address resolver
 	const sETHSynth = synths.find(synth => synth.currencyKey === 'sETH');
 	const sUSDSynth = synths.find(synth => synth.currencyKey === 'sUSD');
-	deployer.link(SafeDecimalMath, EtherCollateral);
+	await deployer.link(SafeDecimalMath, EtherCollateral);
 	const etherCollateral = await deploy(EtherCollateral, owner, resolver.address, {
 		from: deployerAccount,
 	});
@@ -386,7 +387,7 @@ module.exports = async function(deployer, network, accounts) {
 	// Exchanger
 	// ----------------
 	console.log(gray('Deploying Exchanger...'));
-	deployer.link(SafeDecimalMath, Exchanger);
+	await deployer.link(SafeDecimalMath, Exchanger);
 	const exchanger = await deploy(Exchanger, owner, resolver.address, {
 		from: deployerAccount,
 	});
@@ -395,7 +396,7 @@ module.exports = async function(deployer, network, accounts) {
 	// ExchangeState
 	// ----------------
 	console.log(gray('Deploying ExchangeState...'));
-	// deployer.link(SafeDecimalMath, ExchangeState);
+	// await deployer.link(SafeDecimalMath, ExchangeState);
 	const exchangeState = await deploy(ExchangeState, owner, exchanger.address, {
 		from: deployerAccount,
 	});
@@ -404,7 +405,7 @@ module.exports = async function(deployer, network, accounts) {
 	// Issuer
 	// ----------------
 	console.log(gray('Deploying Issuer...'));
-	deployer.link(SafeDecimalMath, Issuer);
+	await deployer.link(SafeDecimalMath, Issuer);
 	const issuer = await deploy(Issuer, owner, resolver.address, { from: deployerAccount });
 
 	console.log(gray('Deploying IssuanceEternalStorage...'));