Merged
Conversation
0xtj24
commented
Jan 10, 2026
0xtj24
commented
- Add FeedSwitchV2
08xmt
reviewed
Jan 13, 2026
wavey0x
reviewed
Jan 20, 2026
|
|
||
| /// @notice Toggle the feed switch, entering or exiting the timelock period | ||
| /// @dev Can only be called by the guardian | ||
| function toggleFeedSwitch() external { |
There was a problem hiding this comment.
note:
current implentation is functionally correct, but semantics differ from conventional timelocks which may lead to confusion for integrators
- toggle function is used both to queue a switch and cancel an in-flight switch
- the feed storage variable is updated immediately, may lead to confusion for integrators as which is the active
FeedSwitchInitiatedis emitted even on cancelations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.