Show the error message if the OAuth failed #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Connect to QuickBooks flow failed, this shows the error message received on the page so that the user can be alerted to fix the problem. Before this change, the callback page ignored the error and attempted to get a token anyway, resulting in a confusing PHP error message (see IntuitDeveloper#2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Connect to QuickBooks flow failed, this shows the error message received on the page so that the user can be alerted to fix the problem. Before this change, the callback page ignored the error and attempted to get a token anyway, resulting in a confusing PHP error message (see #2).
TIP: Click Cancel in the pop-up login window after clicking "Connect to QuickBooks" in the index page to see this new functionality in action.