Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to equal sign - '=' - on URL #1091

Merged

Conversation

jaircuevajunior
Copy link
Contributor

Updated filename regex pattern to allow the equal sign as being part of the filename portion of the route, otherwise it would fall on 404 error.

Updated filename regex pattern to allow the equal sign as being part of the filename portion of the route, otherwise it would fall on 404 error.
@olivervogel
Copy link
Member

Can you elaborate, when this error occurs?

@jaircuevajunior
Copy link
Contributor Author

Sure.
In this case I was using a base64 encoded string as filename (which sometimes ends with an equal sign).
I realized that when the equal sign is present on URL, the route is not recognized.
I'm using intervention/imagecache for this but the route is created in this package (intervention/image) service provider.

To clarify, for instance:

Let's take 'images/cache' as the imagecache route.
If I try to get images/cache/module_desk/uploads/module_avatar/KEQbRnXa47uqIFaEoUutsD98lqc5Rv-metaQmFubmVyLW1vYmlsZS5qcGc=-.jpg it doesn't work, because it fails the regex, so the route is not even called.

@olivervogel olivervogel merged commit 936ec68 into Intervention:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants