fix(benchmark): update valueContains comment for isSubmapOfBy algorithm #7458
+1,081
−1,102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The valueContainsArgs benchmark comment described the old lookup-based algorithm. After PR #7344, valueContains uses Map.isSubmapOfBy which employs a splitLookup-based divide-and-conquer traversal. Changes: - Update comment to accurately describe isSubmapOfBy behavior - Remove unused "deepest entry" selection logic (~30 lines) - Remove unused `find` import The benchmark still generates ~1000 worst-case test points with the same parameter coverage (power-of-2 sizes, worst-case keys, subset relationship). The simplification removes code that was targeting the old algorithm's traversal pattern but had no effect on isSubmapOfBy.
… and builtinCostModelC - Adjusted the 'intercept' value from 1163050 to 1160605 - Updated the 'slope' value from 1470 to 1553 These changes reflect a refinement in the cost estimation for CPU usage in the valueContains section of the cost models.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
valueContainsArgsbenchmark generator to accurately reflect theisSubmapOfByalgorithm introduced in #7344.Problem: The comment and code still described the old lookup-based algorithm where each entry in
containedtriggered an independent lookup from the root of the container BST. This was misleading after the change toMap.isSubmapOfBy.Changes:
isSubmapOfBy(entry order in the list is irrelevant - BST structure determines traversal)findimportWhat's preserved:
Technical Context
The old algorithm did
nindependent lookups from root, making "deepest entry" targeting meaningful. The newisSubmapOfByalgorithm usessplitLookupto divide-and-conquer: after the first split, subsequent lookups happen in subtrees, not from root. Kenneth correctly noted this discrepancy.Test plan
--ghc-options=-Werror