Restructure certifier test modules; add unit testing capability #7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
changed the title
ana-pantilie
added
the
No Changelog Required
ana-pantilie
commented
Apr 22, 2025
| srcTests :: [ String ] | ||
| srcTests = | ||
| [ "inc" | ||
| -- TODO: This is currently failing to certify. This will be fixed |
There was a problem hiding this comment.
@ramsay-t is there an issue which tracks this todo?
| integrationTests = | ||
| testGroup "certifier integration tests" | ||
| [ | ||
| -- testGroup "example serialisation certification" |
There was a problem hiding this comment.
@ramsay-t is there an issue which tracks this commented out test?
ana-pantilie
commented
Apr 22, 2025
Comment on lines
67
to
81
| testTrivialSuccess1 :: TestTree | ||
| testTrivialSuccess1 = | ||
| testSuccess | ||
| "Trivial success" | ||
| FloatDelay | ||
| (mkConstant () (1 :: Integer)) | ||
| (mkConstant () (1 :: Integer)) | ||
|
|
||
| testTrivialFailure1 :: TestTree | ||
| testTrivialFailure1 = | ||
| testFailure | ||
| "Trivial failure" | ||
| FloatDelay | ||
| (mkConstant () (1 :: Integer)) | ||
| (mkConstant () (2 :: Integer)) |
There was a problem hiding this comment.
@ramsay-t It should be very easy to add unit tests now, similar to these two. You provide two terms and the specific optimisation tag.
If you want to test larger traces, that should also be very easy by just constructing the trace manually.
zliu41
reviewed
Apr 22, 2025
There was a problem hiding this comment.
The test names - "integration", "simplifier" and "unit" - aren't quite self-explanatory or accurate.
- "Integration" could mean integration with the executable, or integration with the plugin, or others.
- "Integration" and "Unit" are standard terminology in a testing hierarchy, but "Simplifier" isn't
- The "integration" tests also run the simplifier, except via the executable.
- CSE isn't actually part of the simplifier.
Suggested names: "Executable", "Optimizer", "AST".
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Good idea @zliu41. Applied your suggestions. |
zliu41
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/IntersectMBO/plutus-private/issues/1501