-
Notifications
You must be signed in to change notification settings - Fork 483
refactor: apply fourmolu to plutus-conformance #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the despicable newline, this is an improvement.
-- enough regardless so it doesn't matter. | ||
|
||
-- | The evaluator to be tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the retarded newline.
:: UplcEvaluator | ||
-- ^ The action to run the input through for the tests. | ||
-> (FilePath -> Bool) | ||
{- ^ A function that takes a test name and returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why {- ^
with the space, but {-|
without the space? I'd prefer the latter to have a space too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because in our fourmolu config we have haddock-style: multiline-compact
, could be fixed by haddock-style: multiline
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything that looks too terrible. It looks as if it's reformatting comments to be a maximum of 80 characters wide; I could probably cope with 100 or 120, but it's not a big deal. We've probably argued about this at length before anyway.
@@ -1,7 +1,6 @@ | |||
{-# LANGUAGE CPP #-} | |||
|
|||
{- | Conformance tests for the steppable (debuggable) Haskell implementation. -} | |||
|
|||
-- | Conformance tests for the steppable (debuggable) Haskell implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's happening here? Does it convert one-line {- ... -}
comments into -- ...
?
Also it seems to insist on {-| ...
with no space but it's added -- |
with a space. [Edit: that's probably the same thing that @effectfully mentions later.]
Oh yeah, I'd prefer 100. 120 is too much for me, not sure about 80. |
fourmolu
-ize