Skip to content

refactor: apply fourmolu to plutus-conformance #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Apr 15, 2025

  • Wrap long lines
  • fourmolu-ize

@Unisay Unisay requested review from kwxm and effectfully April 15, 2025 14:53
@Unisay Unisay self-assigned this Apr 15, 2025
@Unisay Unisay added the No Changelog Required Add this to skip the Changelog Check label Apr 15, 2025
Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the despicable newline, this is an improvement.

Comment on lines +61 to 63
-- enough regardless so it doesn't matter.

-- | The evaluator to be tested.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the retarded newline.

:: UplcEvaluator
-- ^ The action to run the input through for the tests.
-> (FilePath -> Bool)
{- ^ A function that takes a test name and returns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why {- ^ with the space, but {-| without the space? I'd prefer the latter to have a space too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because in our fourmolu config we have haddock-style: multiline-compact, could be fixed by haddock-style: multiline.

@Unisay Unisay merged commit 3ee4aa3 into master Apr 16, 2025
7 of 8 checks passed
@Unisay Unisay deleted the yura/fourmolu-plutus-conformance branch April 16, 2025 08:04
Copy link
Contributor

@kwxm kwxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that looks too terrible. It looks as if it's reformatting comments to be a maximum of 80 characters wide; I could probably cope with 100 or 120, but it's not a big deal. We've probably argued about this at length before anyway.

@@ -1,7 +1,6 @@
{-# LANGUAGE CPP #-}

{- | Conformance tests for the steppable (debuggable) Haskell implementation. -}

-- | Conformance tests for the steppable (debuggable) Haskell implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening here? Does it convert one-line {- ... -} comments into -- ...?

Also it seems to insist on {-| ... with no space but it's added -- | with a space. [Edit: that's probably the same thing that @effectfully mentions later.]

@effectfully
Copy link
Contributor

It looks as if it's reformatting comments to be a maximum of 80 characters wide; I could probably cope with 100 or 120

Oh yeah, I'd prefer 100. 120 is too much for me, not sure about 80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants