[UPLC] [Optimization] Add force-ifThenElse-delay #7042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '24dcdb4d21' (base) and '587a9e6523' (PR) Results table
|
|
Click here to check the status of your benchmark. |
effectfully
force-pushed
the
effectfully/optimization/force-ifThenElse-delay
branch
from
587a9e6 to
e9ae45c
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/optimization/force-ifThenElse-delay
branch
from
e9ae45c to
114b4bd
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Comparing benchmark results of 'nofib' on '24dcdb4d21' (base) and '587a9e6523' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '24dcdb4d21' (base) and '114b4bdd0d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '24dcdb4d21' (base) and '114b4bdd0d' (PR) Results table
|
effectfully
force-pushed
the
effectfully/optimization/force-ifThenElse-delay
branch
from
114b4bd to
c11221f
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Well, definitely an improvement, but the benchmarks are less reliable than I thought they were. Here's numbers from two different runs:
|
effectfully
commented
Apr 15, 2025
| Force _ (Delay _ t) -> t | ||
| -- Remove @Delay@s from @ifThenElse@ branches if the latter is @Force@d and the delayed term are | ||
| -- pure and work-free anyway. |
There was a problem hiding this comment.
Should try the same for chooseList/chooseData/caseList/caseData, but let's start with the obvious thing and do it only for ifThenElse for now.
Comment on lines
+1179
to
+1191
| (force ifThenElse | ||
| (equalsInteger 0 index) | ||
| (delay | ||
| (constr 0 [(unBData (force headList args))])) | ||
| (delay | ||
| (force | ||
| (force ifThenElse | ||
| (equalsInteger 1 index) | ||
| (delay | ||
| (constr 1 | ||
| [ (unBData | ||
| (force headList args)) ])) | ||
| (delay (traceError "PT1"))))))) |
There was a problem hiding this comment.
Man casing on Data is gonna be a big deal.
| (force ifThenElse | ||
| (lessThanInteger 0 x) | ||
| (delay (constr 1 [])) | ||
| (delay (constr 0 [])))) |
There was a problem hiding this comment.
Wait, how is this not optimized?
There was a problem hiding this comment.
Addressed by 68a00d1.
effectfully
commented
Apr 15, 2025
Comment on lines
0
to
1
| 1890 No newline at end of file | ||
| 1782 |
Comment on lines
0
to
1
| 3371 No newline at end of file | ||
| 3149 |
Comment on lines
0
to
2
| ({cpu: 6062960 | ||
| | mem: 30520}) No newline at end of file | ||
| ({cpu: 5742960 | ||
| | mem: 28520}) |
There was a problem hiding this comment.
-5.3% CPU and -6.6% MEM.
Comment on lines
0
to
2
| ({cpu: 941965986 | ||
| | mem: 4508802}) No newline at end of file | ||
| ({cpu: 909933986 | ||
| | mem: 4308602}) |
There was a problem hiding this comment.
-3.4% CPU and -4.4% MEM.
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
zliu41
approved these changes
Apr 16, 2025
effectfully
force-pushed
the
effectfully/optimization/force-ifThenElse-delay
branch
from
68a00d1 to
9e53d84
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Done. |
There was a problem hiding this comment.
Sorry for reviewing this late! I think it's fine if the ifThenElse is fully applied. @ramsay-t we'll have to modify the certifier as well, I created an issue for you: https://github.com/IntersectMBO/plutus-private/issues/1545.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements force-delay cancellation when delays appear under
ifThenElse.Serves the same purpose as #7040, but does it better.