Drop Support for GHC 8.10 #7037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeme-wana
commented
Apr 14, 2025
plutus-benchmark/marlowe/README.md
Outdated
| @@ -71,7 +71,7 @@ The golden files contain the counted CPU and memory budget of the scripts. | |||
|
|
|||
| ### Versioning of `marlowe-internal` | |||
|
|
|||
| Note that the off-chain code is evolving. However the on-chain code is very stable and is compatible with GHC 8.10.7. For best benchmarking results, eventually we may have to update some of these files by hand if the on chain code is updated. (We don't want to depend on the Marlowe repository because this will have the problem of circular dependency.) | |||
| Note that the off-chain code is evolving. However the on-chain code is very stable and is compatible with !!! GHC 8.10.7. For best benchmarking results, eventually we may have to update some of these files by hand if the on chain code is updated. (We don't want to depend on the Marlowe repository because this will have the problem of circular dependency.) | |||
There was a problem hiding this comment.
Is this note still relevant?
zeme-wana
commented
Apr 14, 2025
| @@ -166,7 +166,7 @@ GHC Core. Not doing so results in 20+% larger Core for builtins. | |||
|
|
|||
| However in a few specific cases we use @NOINLINE@ instead to get tighter Core. @NOINLINE@ is the | |||
| same as @OPAQUE@ except the latter _actually_ prevents GHC from inlining the definition unlike the | |||
| former (we use the former because we currently have to support GHC-8.10). | |||
| former (we use the former because we currently have to support !!! GHC-8.10). | |||
There was a problem hiding this comment.
Should we replace all NOINLINE with OPAQUE?
zeme-wana
commented
Apr 14, 2025
zeme-wana
commented
Apr 14, 2025
zeme-wana
commented
Apr 14, 2025
zeme-wana
commented
Apr 14, 2025
kwxm
reviewed
Apr 15, 2025
There was a problem hiding this comment.
This looks OK to me, although I'm not very familiar with some of the stuff that mentions 8.10 (like the Marlowe benchmarks), so we should wait for review from other people. There might be other things that we can improve with 8.10 gone, but it's hard to be sure if there aren't any comments saying so.
effectfully
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Impressive how you managed to track down all this very diverse and often implicit references to GHC-8.10.
I just pushed a few commits to the branch reversing some of the stuff we did earlier to support GHC-8.10. Hope I didn't break anything, but it's possible, so please bear with me in that case.
plutus-benchmark/marlowe/README.md
Outdated
| @@ -71,7 +71,7 @@ The golden files contain the counted CPU and memory budget of the scripts. | |||
|
|
|||
| ### Versioning of `marlowe-internal` | |||
|
|
|||
| Note that the off-chain code is evolving. However the on-chain code is very stable and is compatible with GHC 8.10.7. For best benchmarking results, eventually we may have to update some of these files by hand if the on chain code is updated. (We don't want to depend on the Marlowe repository because this will have the problem of circular dependency.) | |||
| Note that the off-chain code is evolving. However the on-chain code is very stable and is compatible with !!! GHC 8.10.7. For best benchmarking results, eventually we may have to update some of these files by hand if the on chain code is updated. (We don't want to depend on the Marlowe repository because this will have the problem of circular dependency.) | |||
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
kwxm
reviewed
Apr 29, 2025
There was a problem hiding this comment.
This has changed because of the replacement of some variable names with underscores here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for GHC 8.10.