[Builtins] Allow casing on booleans and integers #7029
+560
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
8358a8f to
5244c96
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
5244c96 to
8b55532
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
8b55532 to
2344b92
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
2344b92 to
c0df0c1
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
c0df0c1 to
06d1a16
Compare
…to effectfully/builtins/allow-casing-on-booleans
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '40b3e8c4d' (base) and '5f3483866' (PR) Results table
|
|
Performance looks pretty much unaffected. |
zliu41
reviewed
Jun 6, 2025
| -- this type isn't supported at all). | ||
| caseBuiltin :: UniOf term ~ uni => Some (ValueOf uni) -> Vector term -> Either Text term | ||
|
|
||
| data CaserBuiltin uni = CaserBuiltin |
There was a problem hiding this comment.
It seems CaserBuiltin should render the CaseBuiltin class superfluous, since an instance of CaseBuiltin can just be represented with a CaserBuiltin value?
Also, why not newtype?
There was a problem hiding this comment.
There was a problem hiding this comment.
We do use CaseBuiltin as an actual constraint
Ok, so Case is used to define how a universe normally handles casing on builtins, and Caser exists so that it can vary based on protocol version. I guess that's fine, but not easy to tell, and their similar names don't help.
See this for a similar case.
Create a Note and link to it?
zliu41
approved these changes
Jun 6, 2025
| -- this type isn't supported at all). | ||
| caseBuiltin :: UniOf term ~ uni => Some (ValueOf uni) -> Vector term -> Either Text term | ||
|
|
||
| data CaserBuiltin uni = CaserBuiltin |
There was a problem hiding this comment.
We do use CaseBuiltin as an actual constraint
Ok, so Case is used to define how a universe normally handles casing on builtins, and Caser exists so that it can vary based on protocol version. I guess that's fine, but not easy to tell, and their similar names don't help.
See this for a similar case.
Create a Note and link to it?
|
I'll review this soon so that I actually have some idea of what's going on. If we're committed to releasing this then there are some other things that'll need to be done:
|
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
5f34838 to
2748dbb
Compare
…to effectfully/builtins/allow-casing-on-booleans
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for casing on booleans and integers using
Case, which is the first part of #6602.