Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlutusLedgerApi.V1.withCurrencySymbol #6636

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

PlutusLedgerApi.V1.withCurrencySymbol #6636

wants to merge 2 commits into from

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Nov 5, 2024

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Unisay Unisay changed the title Yura/with currency symbol PlutusLedgerApi.V1.withCurrencySymbol Nov 5, 2024
@Unisay Unisay requested a review from zliu41 November 5, 2024 14:24
zliu41
zliu41 reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the issue? I don't remember why this is needed. Also please add tests.

plutus-ledger-api/src/PlutusLedgerApi/V1/Value.hs
{-# LANGUAGE DataKinds #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE UndecidableInstances #-}
-- We need -fexpose-all-unfoldings to compile the Marlowe validator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be preserved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliu41 zliu41 zliu41 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unisay @zliu41