Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Agda interface to shiftByteString and rotateByteString #6385

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kwxm
Copy link
Contributor

@kwxm kwxm commented Aug 7, 2024

The Agda interface to shiftByteString and rotateByteString was bypassing the wrappers, which led to rotateByteString handling negative rotations incorrectly: this should fix that problem.

@kwxm kwxm added the No Changelog Required Add this to skip the Changelog Check label Aug 7, 2024
@kwxm kwxm enabled auto-merge (squash) August 7, 2024 03:56
@kwxm kwxm changed the title Fix shiftByteString and rotateByteString Fix Agda interface to shiftByteString and rotateByteString Aug 7, 2024
@kwxm kwxm merged commit 18b4174 into master Aug 7, 2024
7 checks passed
@kwxm kwxm deleted the kwxm/metatheory/fix-shift-rotate branch August 7, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant