HasBlueprintSchema and HasBlueprintDefinition instances #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
force-pushed
the
yura/has-schema-instances
branch
8 times, most recently
from
da90e6b
to
7046453
Compare
Unisay
changed the title
Unisay
force-pushed
the
yura/has-schema-instances
branch
3 times, most recently
from
7057c67
to
d5afe39
Compare
zeme-wana
force-pushed
the
master
branch
2 times, most recently
from
a161078
to
db5cabb
Compare
zliu41
reviewed
Jul 25, 2024
| {-# LANGUAGE DerivingVia #-} | ||
| {-# LANGUAGE FlexibleInstances #-} | ||
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE TypeApplications #-} | ||
|
|
||
| {-# OPTIONS_GHC -Wno-orphans #-} |
There was a problem hiding this comment.
There are a bunch of these in plutus-ledger-api. What are they for?
There was a problem hiding this comment.
Not sure. Pretty likely they became obsolete. I've removed them, lets and if build doesn't fail (which it didn't locally).
zliu41
approved these changes
Aug 24, 2024
Unisay
force-pushed
the
yura/has-schema-instances
branch
from
1ebe4ce
to
bac2190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes in these categories:
AsDefinitionIdtypeclass renamed toHasBlueprintDefinitionHasSchematypeclass renamed toHasBlueprintSchemaUnrolltype-family is made associated with theHasBlueprintDefinitiontypeclass, allowing extensibility.HasBlueprintSchemaandHasBlueprintDefinitioninstances for data types in theplutus-ledger-apiand ones exported by thePlutusTx.Prelude.Closes #6265