Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump haskell.nix #5120

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

andreabedini
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@zeme-iohk
Copy link

No objection to this, but why the bump?

@andreabedini
Copy link
Contributor Author

No objection to this, but why the bump?

Marking it as draft doesn't spare me from explaining myself 😆

The bump is to support cabal file revisions on CHaP which are necessary to get our packages to build without all those manual constraints we have in cabal.project.

I opened a draft PR to test the waters and warm up the chaces ahead of time since it's relatively big change in haskell.nix. I'll make sure everything works and then mark it as ready.

@michaelpj
Copy link
Contributor

plutus maybe isn't the most interesting project to try this on since we actually don't have a mess of constraints because we don't depend on that many cardano projects?

@andreabedini andreabedini marked this pull request as ready for review February 14, 2023 01:45
@andreabedini
Copy link
Contributor Author

This seems to have gone smoothly so I am marking it as ready.

@zeme-iohk zeme-iohk self-requested a review February 14, 2023 02:35
@michaelpj michaelpj merged commit f2735e7 into IntersectMBO:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants