Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new stack by removing absolute symlink #1181

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Fix new stack by removing absolute symlink #1181

merged 2 commits into from
Jun 27, 2019

Conversation

michaelpj
Copy link
Contributor

Fixes #1180.

Workaround for commercialhaskell/stack#4913.

@michaelpj michaelpj requested a review from shmish111 June 27, 2019 09:37
@michaelpj
Copy link
Contributor Author

Hang on, might need another fix to get it to build.

@michaelpj
Copy link
Contributor Author

Okay, I succesfully did stack build, looks like we're good to go.

shmish111
shmish111 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@shmish111 shmish111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it passes checks then happy to merge

@michaelpj michaelpj merged commit a79543d into IntersectMBO:master Jun 27, 2019
@michaelpj michaelpj deleted the fix/stack-absolute-symlink branch June 27, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmish111 shmish111 shmish111 approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build with stack
2 participants
@michaelpj @shmish111