Skip to content

Conversation

@geo2a
Copy link
Contributor

@geo2a geo2a commented Feb 10, 2025

Description

This is a draft PR that may address IntersectMBO/ouroboros-consensus#1370. See the issue for further discussion, as it is not clear is ouroboros-network is the right place for this change.

This PR:

The query type is modeled after the one defined in Ouroboros.Consensus.Ledger.Query, which is used to instantiate the LocalStateQuery in the Consensus code.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@geo2a geo2a force-pushed the geo2a/consensus-issue-1370-refine-local-state-query branch from 6073392 to 3d541f4 Compare February 11, 2025 15:49
@geo2a geo2a force-pushed the geo2a/consensus-issue-1370-refine-local-state-query branch from 3d541f4 to db8d673 Compare February 25, 2025 14:41
@geo2a geo2a force-pushed the geo2a/consensus-issue-1370-refine-local-state-query branch from db8d673 to a3c3925 Compare March 10, 2025 10:59
@geo2a geo2a force-pushed the geo2a/consensus-issue-1370-refine-local-state-query branch from a3c3925 to c57cbd8 Compare March 10, 2025 11:00
@geo2a
Copy link
Contributor Author

geo2a commented Mar 26, 2025

Closing this PR, as we've decided to store Consensus-specific CDDLs in the consensus repository. See IntersectMBO/ouroboros-consensus#1430

@geo2a geo2a closed this Mar 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants