ObjectDiffusion v2 (just inbound side changes) for efficient vote retrieval

[tbagrel1]

Co-authored-by: nbacquey nbacquey@users.noreply.github.com

Description

Please include a meaningful description of the PR and link the relevant issues
this PR might resolve.

Also note that:

• New code should be properly tested (even if it does not add new features).
• The fix for a regression should include a test that reproduces said regression.

[tbagrel1]

Using IntersectMBO/ouroboros-network@0db8669

[agustinmista]

Some initial comments. I still need to take a look in depth at:

• ObjectDiffusion/Inbound/V2/Decision.hs
• ObjectDiffusion/Inbound/V2/Registry.hs
• ObjectDiffusion/Inbound/V2/State.hs
• Benchmarking commit

[agustinmista]

Another round of comments.

[tbagrel1]

FTR, I'm a bit unsure about introducing a proper data type PeerDecision with two fields that are also new data types (4999b52).

In the end, instead of a single PeerDecision type, we now have four: PeerDecisionStatus > PeerDecision > {ReqIdsDecision, ReqObjectsDecision}. This seems a bit heavy, especially since these datatypes won't be enriched with new fields in the future.
We now have a much more verbose code structure just to make a specific state unrepresentable even though it wasn't really problematic/unsafe to begin with.

But I don't see a nicer alternative atm than what we already had before or what we have now... I initially used a plain tuple instead of the new PeerDecision type, but it isn't very satisfying either.

[tbagrel1]

I pushed a few changes:

• Fixed formatting on a couple of fairly long lines
• Updated documentation in V2.md to reflect the new system of status for decisions
• Squashed commits