Bugfix for Byron deserialization of Ledger Tables #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/bugfix-byron-decoding
branch
from
a3b9957 to
f3da702
Compare
This was referenced Jul 2, 2025
dnadales
approved these changes
Jul 2, 2025
kderme
added a commit
to IntersectMBO/cardano-db-sync
that referenced
this pull request
Sep 4, 2025
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further
kderme
added a commit
to IntersectMBO/cardano-db-sync
that referenced
this pull request
Oct 18, 2025
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further
kderme
added a commit
to IntersectMBO/cardano-db-sync
that referenced
this pull request
Oct 18, 2025
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further Signed-off-by: Kostas Dermentzis <kostas.dermentzis@iohk.io>
kderme
added a commit
to IntersectMBO/cardano-db-sync
that referenced
this pull request
Oct 18, 2025
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further Signed-off-by: Kostas Dermentzis <kostas.dermentzis@iohk.io>
kderme
added a commit
to IntersectMBO/cardano-db-sync
that referenced
this pull request
Nov 12, 2025
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further Signed-off-by: Kostas Dermentzis <kostas.dermentzis@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were encoding a map length of
0, but were not decoding it.