Run lockstep tests with IOSim
#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
jorisdral
force-pushed
the
jdral/lockstep-io-sim
branch
from
e8a4307 to
3966443
Compare
dcoutts
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Looks good, but I think we should take the opportunity to make sure we've got a reasonably strong test that closing table handles frees what we expect. A minimal version of that would simply be closing all table handles at the end of a run.
Separately we also want to verify that closeSession also cleans things up.
Currently we just test the latter but not the former.
…cked Before this change, a successfull `tryLockFile` would not contribute to the number of open file handles. Instead, it would open a read-write handle to increment/decrement a counter in the locked file, after which the handle is released again before returning a `LockFileHandle`. To check whether a file has been fully unlocked, we would have to read the contents of the locked file, which is more complicated than it has to be. Instead, we now ensure that `tryLockFile` acquires a read handle after updating the counter in the file, and this handle is only released after calling `hUnlock` on the `LockFileHandle`. As such, a file lock will contribute to the number of open file handles in a `MockFS`. Our tests can then simply read this number, and make assertions about the number.
jorisdral
force-pushed
the
jdral/lockstep-io-sim
branch
from
3966443 to
174e25f
Compare
dcoutts
approved these changes
Oct 9, 2024
|
Feel free to squash and merge. |
This has some implications for `retrieveBlobs`: we remove the `Typeable m` constraint, which is not satisfiable for `IOSim s` due to the state type `s`, which is polymorphic. It turns out we do not need that constraint anyway, because it is only the existential type variables for file handles have to be checked for type equality.
jorisdral
force-pushed
the
jdral/lockstep-io-sim
branch
from
174e25f to
df8a546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #415. See the commit messages for more details.