Alternative ModelIO instance for the reference implementation
#403
+785
−1,646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/unify-IO-models
branch
from
56d1c73
to
850b4a8
Compare
|
A bit of explanation of motivation would be good here. |
dcoutts
reviewed
Sep 30, 2024
There was a problem hiding this comment.
This looks ok, and it's nice to have a clear structure and less duplication. What I want to see somewhere in these models and instances is a high level explanation of them all. A reader coming to see and understand needs some guidance. And then elsewhere perhaps links back to the central explanation.
| => Maybe k | ||
| -> h m k v blob | ||
| -> (Cursor h m k v blob -> m a) | ||
| -> m a | ||
| withCursor offset hdl = bracket (newCursor offset hdl) (closeCursor (Proxy @h)) | ||
|
|
||
| {------------------------------------------------------------------------------- | ||
| Model instance | ||
| Model 2 instance |
There was a problem hiding this comment.
Want some docs somewhere that says what we're doing here with these different models. There's a hierarchy, but no explanation of what it is.
jorisdral
force-pushed
the
jdral/unify-IO-models
branch
from
416c70b
to
4ce8ef4
Compare
Alternative `ModelIO` instance for the reference implementation Use the pure model with a tiny wrapper Remove ModelIO.Normal TOSQUASH: Alternative `ModelIO` instance WIP: one model WIP: full cleanup
mheinzel
force-pushed
the
jdral/unify-IO-models
branch
from
4ce8ef4
to
78e3ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP