Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF cleanup 282: rename sucᵉ to 1 +ᵉ_ #363

Closed
wants to merge 1 commit into from

Conversation

williamdemeo
Copy link
Contributor

@williamdemeo williamdemeo commented Feb 14, 2024

Description

Second attempt to rename sucᵉ, this time using a simpler approach---simply replace it with 1 +ᵉ_.

This addresses one item of issue #282.

Maybe this is not idea, but I'm not sure there's a better alternative if we can't identify Epoch as one of the simple/standard types of algebraic structures for which there is already support for literals.

It was suggested in the comments of previous PR #315 (since closed) that Epoch has a module structure, but I don't see it. To me Epoch looks more like a G-set, where the group acting on Epoch is ℕ` ...and I don't know if there's support for G-set literals ...yet. If there is
not, then we could develop it, but I'm not sure it's worth doing for the sole purpose of renaming one symbol.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@WhatisRT
Copy link
Collaborator

It'd be better to instead make an epoch 1ᵉ, so that you can write 1ᵉ +_ for sucᵉ. That way we can then just use literal overloading to get rid of the entirely.

@williamdemeo
Copy link
Contributor Author

williamdemeo commented Feb 18, 2024

It'd be better to instead make an epoch 1ᵉ, so that you can write 1ᵉ +_ for sucᵉ. That way we can then just use literal overloading to get rid of the entirely.

Okay, I'll try that... I'm not sure off the top of my head how 1ᵉ should be defined off the top of my head, but I'll look again at the code and see if I can figure it out... If not, I'll ask.

@WhatisRT WhatisRT mentioned this pull request Apr 4, 2024
3 tasks
@WhatisRT
Copy link
Collaborator

WhatisRT commented Apr 4, 2024

Closing in favour of #387

@WhatisRT WhatisRT closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants