Skip to content

Set the correct magic field#30

Merged
crocodile-dentist merged 1 commit intomainfrom
karknu/cardano-magic
Feb 11, 2026
Merged

Set the correct magic field#30
crocodile-dentist merged 1 commit intomainfrom
karknu/cardano-magic

Conversation

@karknu
Copy link
Contributor

@karknu karknu commented Jan 26, 2026

List of changes

  • When one specifies the cardano-network-magic cli option it should set the cardano network's magic not the dmq network's magic.
  • Add dqm-network-magic cli option for setting the dmq network's magic.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Jan 26, 2026
@karknu karknu force-pushed the karknu/cardano-magic branch from db79690 to 2f1f123 Compare January 26, 2026 14:55
@karknu karknu marked this pull request as ready for review January 26, 2026 14:58
@karknu karknu force-pushed the karknu/cardano-magic branch 2 times, most recently from 829ecbb to 02195f7 Compare January 27, 2026 07:53
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

When one specifies the cardano-network-magic cli option it should set
the cardano network's magic not the dmq network's magic.
Add cli dmq-network-magic option for setting the dmq network's magic.
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit c678045 Feb 11, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants