Conversation
coot
reviewed
Jan 15, 2026
coot
reviewed
Jan 15, 2026
coot
reviewed
Jan 15, 2026
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
from
7f46a53 to
0880f8e
Compare
coot
reviewed
Jan 20, 2026
Verify that `Sig` encoding produces a valid CBOR.
`SigSubmissionV2` protocol based on `ObjectDiffusion` from Peras. The client requests signatures while the server provides them (dual to `TxSubmission`). The patch provides: * protocol definition and GADT wrappers * CBOR codec * cddl specification checked against the codec * codec provides valid CBOR encoding (checked as a regular QC test rather than with the `cddl` tool)
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
from
13271d6 to
6883ba0
Compare
Comment on lines
+74
to
+77
| case initDelay of | ||
| TxSubmissionInitDelay delay -> threadDelay delay | ||
| NoTxSubmissionInitDelay -> return () | ||
| inboundIdle |
Contributor
There was a problem hiding this comment.
The initial delay makes sense for tx-submission where the server/upstream downloads from the client/downstream. In that case, the server makes sure the client behaves for the timeout period before fetching any tx's. Here, the client connects and should start working immediately.
| serverReqSigIds | ||
| -- if there are no unacknowledged sigids, the protocol requires sending | ||
| -- a blocking `MsgRequestSigIds` request. This is important, as otherwise | ||
| -- the client side wouldn't have a chance to terminate the |
Contributor
There was a problem hiding this comment.
s/client/server/?
Comment on lines
+100
to
+103
| SigSubmissionOutbound (pure (client Seq.empty mempoolZeroIdx)) | ||
| where | ||
| client :: StrictSeq (sigId, idx) -> idx -> OutboundStIdle sigId sig m () | ||
| client !unackedSeq !lastIdx = |
Contributor
There was a problem hiding this comment.
s/client/server/
Comment on lines
+199
to
+200
| let sigs = mapMaybe mempoolLookupTx sigIdxs' | ||
| client' = client unackedSeq lastIdx |
Comment on lines
+152
to
+157
| sigs <- atomically $ | ||
| do | ||
| MempoolSnapshot{mempoolTxIdsAfter} <- mempoolGetSnapshot | ||
| let sigs = mempoolTxIdsAfter lastIdx | ||
| check (not $ null sigs) | ||
| pure (take (fromIntegral reqNo) sigs) |
Contributor
There was a problem hiding this comment.
We should add a timeout here (< limit for SingSigIds SingBlocking) and return SendMsgReplyNoSigIds below to hand over the agency so the client can either close the connection or issue another blocking call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Closes #13
Checklist