Skip to content

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Apr 10, 2025

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@aniketd aniketd requested a review from a team April 10, 2025 10:17
@aniketd aniketd requested review from a team as code owners April 10, 2025 10:17
@aniketd aniketd force-pushed the aniketd/fixup-version-10-3 branch from 86409c4 to 91d1744 Compare April 10, 2025 10:22
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side this looks good

@aniketd aniketd force-pushed the aniketd/fixup-version-10-3 branch 2 times, most recently from 9226483 to 61cbfa6 Compare April 10, 2025 11:10
@aniketd aniketd force-pushed the aniketd/fixup-version-10-3 branch from 61cbfa6 to 7d2abc3 Compare April 10, 2025 11:21
@aniketd aniketd enabled auto-merge April 10, 2025 11:24
@aniketd aniketd added this pull request to the merge queue Apr 10, 2025
Merged via the queue into master with commit d0dcd9b Apr 10, 2025
24 checks passed
@aniketd aniketd deleted the aniketd/fixup-version-10-3 branch April 10, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants